Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Support latest GitHub runners, use latest working EDK2 release tag #1

Closed
wants to merge 1 commit into from

Conversation

olljanat
Copy link
Contributor

I was planning to create pull request to add support for loongarch64 but noticed that CI broken this PR fixes those:

Reasons to changes:

@pbatard
Copy link
Owner

pbatard commented Jan 21, 2025

Sounds good. I'm just going to move the EDK2 tag into an environment variable, so that it's easier to spot that it's something that should be updated (and make sure that we actually use the latest working EDK2 which is 2024.11 rather than 2024.08).

Note that if you plan to add LoongArch support (which I am planning to do regardless at some stage), you may want to look at what I did in EfiFs or in UEFI Shell because I'll want something that's very close to that.

But many thanks for this PR!

@pbatard pbatard closed this in 88d9fc9 Jan 21, 2025
@pbatard
Copy link
Owner

pbatard commented Jan 21, 2025

And now I know why you used 2024.08... I remember having to fix the stuff that moved around, but please, in the future, avoid proposing PRs that hold back on a toolchain because it breaks compilation, and instead try to propose a fix so that compilation works with the updated toolchain.

@pbatard
Copy link
Owner

pbatard commented Jan 21, 2025

I have now fixed the build with recent EDK2 and added LoongArch64 build support while I was at it. See a33daa5. I'll add LoongArch64 to the tests at a later stage...

@olljanat olljanat deleted the fix-ci branch January 21, 2025 23:18
@olljanat
Copy link
Contributor Author

I have now fixed the build with recent EDK2 and added LoongArch64 build support while I was at it.

That was fast thanks.

And now I know why you used 2024.08... I remember having to fix the stuff that moved around, but please, in the future, avoid proposing PRs that hold back on a toolchain because it breaks compilation, and instead try to propose a fix so that compilation works with the updated toolchain.

Well, I wasn’t actually able to build this locally at all and when you are first pull request creator in repo you also don’t want spent too much time before seeing that how PRs are handled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants