[BUG] Italics nested in bold are not bold in preview

[athyfr]

Expected behaviour

Italics and bold combine when italics are nested inside bold.

Like this example (rendered using GitHub Markdown): **bold *and italic*** -> bold and italic

Actual behaviour

The nested italic just looks like regular italic (in the preview window):

It looks fine in the editor, though.

Steps to reproduce

Steps to reproduce the behavior:

Copy and paste this text (**bold *and italic***) to a note in QOwnNotes, and look at the preview window.

It looks fine in the editor, but not the preview window.

Proposed solution

Separate the theming for 'bold & italic' from 'bold' and 'italic' in the editor theming.

Another popular note-taking app (Obsidian) uses this approach, which I find works quite well.

It also allows for the combination to have a different color than either others, which would allow for more freedom.

[pbek]

The generated HTML is correct, <strong>bold <em>and italic</em></strong>, but the CSS styles for em are setting font-weight normal.

@Waqar144, can you maybe remember something about that?

[Waqar144]

This used to work IIRC. The style needs to be merged with existing style. So if bold exists, the italic should merge with bold instead of overwriting. This is definitely a markdownhighlighter bug

[pbek]

Thank you. The highlighting in the editor works in the way it should, it's only the preview. I'll look into it.

[pbek]

I fixed the CSS styles, but the QTextBrowser still is rendering the combination wrong.

[pbek]

By adding styles for all permutations i b, em b, i strong, em strong, b i, strong i, b em, strong em I was able to get around the QTextBrowser issue!

[pbek]

[pbek]

25.1.6

• An issue with combinations of strong and em tags preview was fixed
  (for #3218)

[pbek]

There now is a new release, could you please test it and report if it works for you?

[athyfr]

It works now, thanks!:

I'll close the issue.

I was amazed by the fast response times, and look forward to exploring your app further, thanks!

[pbek]

Great, thank you for testing! 😉