ggplot2 2.2.0 breaks aread and asearch examples in documentation

[pbiecek]

@MarcinKosinski We have to decide how to handle problems with updates in ggplot2
I guess that they have changes the structure of gg object

I found: 1 error  | 0 warnings | 2 notes.

    checking examples ... ERROR
    Running examples in ‘archivist-Ex.R’ failed
    The error most likely occurred in:

    > base::assign(".ptime", proc.time(), pos = "CheckExEnv")
    > ### Name: aread
    > ### Title: Read Artifacts Given as md5hashes from the Repository
    > ### Aliases: aread
    >
    > ### ** Examples
    >
    > # read the object from local directory
    > setLocalRepo(system.file("graphGallery", package = "archivist"))
    > pl <- aread("f05f0ed0662fe01850ec1b928830ef32")
    > # plot it
    > pl
    Error in stopifnot(is.list(x), is.list(val)) :
      attempt to apply non-function
    Calls: <Anonymous> ... ggplot_build -> <Anonymous> -> f ->
<Anonymous> -> stopifnot
    Execution halted

    checking package dependencies ... NOTE
    Package which this enhances but not available for checking:
‘archivist.github’

    checking Rd cross-references ... NOTE
    Package unavailable to check Rd xrefs: ‘archivist.github’

[MarcinKosinski]

Archive also plot/print function for the archied object ? that's connected
to the object like we do with datasets?

2016-10-05 14:16 GMT+02:00 Przemysław Biecek notifications@github.com:

@MarcinKosinski https://github.com/MarcinKosinski We have to decide how
to handle problems with updates in ggplot2
I guess that they have changes the structure of gg object

I found: 1 error | 0 warnings | 2 notes.

checking examples ... ERROR
Running examples in ‘archivist-Ex.R’ failed
The error most likely occurred in:

> base::assign(".ptime", proc.time(), pos = "CheckExEnv")
> ### Name: aread
> ### Title: Read Artifacts Given as md5hashes from the Repository
> ### Aliases: aread
>
> ### ** Examples
>
> # read the object from local directory
> setLocalRepo(system.file("graphGallery", package = "archivist"))
> pl <- aread("f05f0ed0662fe01850ec1b928830ef32")
> # plot it
> pl
Error in stopifnot(is.list(x), is.list(val)) :
  attempt to apply non-function
Calls: <Anonymous> ... ggplot_build -> <Anonymous> -> f ->

-> stopifnot
Execution halted

checking package dependencies ... NOTE
Package which this enhances but not available for checking:

‘archivist.github’

checking Rd cross-references ... NOTE
Package unavailable to check Rd xrefs: ‘archivist.github’

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#296, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGdazhLiV3UdbUS3mMvYDkQh7HecvEwGks5qw5UagaJpZM4KOutF
.

[pbiecek]

But the plot() function may rely on some other internal function.
Is it possible to track all dependencies and store all of them?

Dnia 05.10.2016 o godz. 15:03 Marcin Kosiński notifications@github.com napisał(a):

Archive also plot/print function for the archied object ? that's connected
to the object like we do with datasets?

2016-10-05 14:16 GMT+02:00 Przemysław Biecek notifications@github.com:

@MarcinKosinski https://github.com/MarcinKosinski We have to decide how
to handle problems with updates in ggplot2
I guess that they have changes the structure of gg object

I found: 1 error | 0 warnings | 2 notes.

checking examples ... ERROR
Running examples in ‘archivist-Ex.R’ failed
The error most likely occurred in:

base::assign(".ptime", proc.time(), pos = "CheckExEnv")

Name: aread

Title: Read Artifacts Given as md5hashes from the Repository

Aliases: aread

** Examples

read the object from local directory

setLocalRepo(system.file("graphGallery", package = "archivist"))
pl <- aread("f05f0ed0662fe01850ec1b928830ef32")

plot it

pl
Error in stopifnot(is.list(x), is.list(val)) :
attempt to apply non-function
Calls: ... ggplot_build -> -> f ->
-> stopifnot
Execution halted

checking package dependencies ... NOTE
Package which this enhances but not available for checking:
‘archivist.github’

checking Rd cross-references ... NOTE
Package unavailable to check Rd xrefs: ‘archivist.github’

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#296, or mute the thread
https://github.com/notifications/unsubscribe-auth/AGdazhLiV3UdbUS3mMvYDkQh7HecvEwGks5qw5UagaJpZM4KOutF
.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

[MarcinKosinski]

1. I suggest to remove ggplot examples from archivist package manual pages.
2. Still no idea what to do with paper submited to JSS.

[pbiecek]

For 2, I will try to prepare the ggconvert function.
It should not be that hard

2016-10-18 15:14 GMT+02:00 Marcin Kosiński notifications@github.com:

1. I suggest to remove ggplot examples from archivist package manual pages.
2. Still no idea what to do with paper submited to JSS.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#296 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AEaPvvbY4T61sb7X89TM8Pbzv-JaGXpdks5q1MY5gaJpZM4KOutF
.

pozdrawiam serdecznie,
Przemysław Biecek

[MarcinKosinski]

I have removed 3 or 4 plotting ggplots examples from documentation and I have added additional info about restoreLibs function if one would like to plot ggplot's and does not have ggplot ver 2.1.0 - the one in which we have archived mose of our objects.

For ggconvert or for the articles issues I would create a new issue.