Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for upcoming ggplot2 change #33

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Update tests for upcoming ggplot2 change #33

merged 1 commit into from
Mar 11, 2024

Conversation

teunbrand
Copy link
Contributor

Hi there,

While preparing for a new release of ggplot2 and during a reverse dependency check, it became apparent that the prospective ggplot2 3.5.0 would break breakDown.

This PR updates a test that implicitly expects the length of ggplot objects to be 9. With the new version, this no longer holds true. Instead the tests expect the plot to be of the same length as a ggplot object.

To test the code changes with the release candidate, you can install it with the code below:

remotes::install_github("tidyverse/ggplot2", ref = remotes::github_pull("5592"))

The release of ggplot2 3.5.0 is scheduled for the 12th of Februari. The progress of the release can be tracked in tidyverse/ggplot2#5588. We hope that this PR might help breakDown get out a fix if necessary.

@teunbrand
Copy link
Contributor Author

This is just a kind reminder that the release is scheduled soon.

@pbiecek
Copy link
Owner

pbiecek commented Mar 11, 2024

thanks

@pbiecek pbiecek merged commit 343f53a into pbiecek:master Mar 11, 2024
@teunbrand teunbrand deleted the ggplot2_3.5.0 branch March 12, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants