Skip to content

Commit

Permalink
👷 Line Coverage requirement: 64%
Browse files Browse the repository at this point in the history
- branch coverage requirement: 44%
  • Loading branch information
pboling committed Sep 17, 2024
1 parent f5447e2 commit 6562e3a
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .envrc
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ export K_SOUP_COV_DO=true # Means you want code coverage
# Available formats are html, xml, rcov, lcov, json, tty
export K_SOUP_COV_COMMAND_NAME="RSpec Coverage"
export K_SOUP_COV_FORMATTERS="html,tty"
export K_SOUP_COV_MIN_BRANCH=45 # Means you want to enforce X% branch coverage
export K_SOUP_COV_MIN_LINE=65 # Means you want to enforce X% line coverage
export K_SOUP_COV_MIN_BRANCH=44 # Means you want to enforce X% branch coverage
export K_SOUP_COV_MIN_LINE=64 # Means you want to enforce X% line coverage
export K_SOUP_COV_MIN_HARD=true # Means you want the build to fail if the coverage thresholds are not met
export K_SOUP_COV_MULTI_FORMATTERS=true
export MAX_ROWS=5 # Setting for simplecov-console gem for tty output, limits to the worst N rows of bad coverage
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
name: Code Coverage

env:
K_SOUP_COV_MIN_BRANCH: 45
K_SOUP_COV_MIN_LINE: 65
K_SOUP_COV_MIN_BRANCH: 44
K_SOUP_COV_MIN_LINE: 64
K_SOUP_COV_MIN_HARD: true
K_SOUP_COV_DO: true
K_SOUP_COV_COMMAND_NAME: "MiniTest Coverage"
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
hide_complexity: true
indicators: true
output: both
thresholds: '100 100'
thresholds: '64 44'
continue-on-error: ${{ matrix.experimental != 'false' }}

- name: Add Coverage PR Comment
Expand Down
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
ruby 3.3.5
ruby 2.7.8
10 changes: 5 additions & 5 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,13 @@ GEM
diff-lcs (>= 1.2.0, < 2.0)
rspec-support (~> 3.13.0)
rspec-support (3.13.1)
rubocop (1.65.1)
rubocop (1.64.1)
json (~> 2.3)
language_server-protocol (>= 3.17.0)
parallel (~> 1.10)
parser (>= 3.3.0.2)
rainbow (>= 2.2.2, < 4.0)
regexp_parser (>= 2.4, < 3.0)
regexp_parser (>= 1.8, < 3.0)
rexml (>= 3.2.5, < 4.0)
rubocop-ast (>= 1.31.1, < 2.0)
ruby-progressbar (~> 1.7)
Expand Down Expand Up @@ -123,10 +123,10 @@ GEM
simplecov-rcov (0.3.7)
simplecov (>= 0.4.1)
simplecov_json_formatter (0.1.4)
standard (1.40.0)
standard (1.37.0)
language_server-protocol (~> 3.17.0.2)
lint_roller (~> 1.0)
rubocop (~> 1.65.0)
rubocop (~> 1.64.0)
standard-custom (~> 1.0.0)
standard-performance (~> 1.4)
standard-custom (1.0.2)
Expand Down Expand Up @@ -175,4 +175,4 @@ DEPENDENCIES
yard-junk (~> 0.0.10)

BUNDLED WITH
2.5.18
2.4.22

0 comments on commit 6562e3a

Please sign in to comment.