Leverage github.com/google/uuid where possible

[pborman]

This change leverages the github.com/google/uuid package where reasonable. There is still duplicated code due to performance reasons.

[harrisonhjones]

For whatever reason I cannot submit my other comment on marshal.go's UnmarshalText function so here it is:

The error pattern I'm used to is usually "flipped" from this:

if err != nil {
    ... handle the error ...
    ... return with wrapped error ...
}
... handle the success ...
return nil

Ie, the "happy path" is on the root indent. Any reason for the different style here? It looks like the existing code (before the change) worked this way.

[harrisonhjones]

I've seen this issue before. Fix can be found here

[pborman]

Thanks for the review and the "travis" fix. Hopefully my latest commit will run properly.

The reason I wrote Array.UnmarshalText as:

        id, err := guuid.ParseBytes(data)
        if err == nil {
                *u = Array(id)
        }
        return err

rather than

        id, err := guuid.ParseBytes(data)
        if err != nil {
                return err
        }
        *u = Array(id)
        return nil

had two weak reasons. The first is err != nil requires two return statements meaning one more line of code. In C, years ago, the thought was there should be only 1 return path in a function so you didn't return out of the middle and miss the cleanup code. The second was to make it clear that the error from ParseBytes was in fact the error being returned (even if it was nil).

I am not tied to either version so I will modify it to do the err != nil.

[pborman]

Resolving conflicts will be simple, but it is not clear to me if I resolve the conflict and click the "merge" button what will happen (will it merge it into the branch or merge the pull request?)

[harrisonhjones]

It looks like there are conflicts in the .travis.yml file but otherwise it looks good to merge. Also not 100% sure what happens if you merge. I would expect it to merge the PR into the master branch.

[pborman]

Thank you for your reviews!