Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pretty printer library switch with ANSI compatibility #428

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion optparse-applicative.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -88,19 +88,22 @@ library
, Options.Applicative.Common
, Options.Applicative.Extra
, Options.Applicative.Help
, Options.Applicative.Help.Ann
, Options.Applicative.Help.Chunk
, Options.Applicative.Help.Core
, Options.Applicative.Help.Levenshtein
, Options.Applicative.Help.Pretty
, Options.Applicative.Help.Style
, Options.Applicative.Help.Types
, Options.Applicative.NonEmpty
, Options.Applicative.Types
, Options.Applicative.Internal

build-depends: base == 4.*
, ansi-terminal >= 0.4.0
, prettyprinter >= 1.7.1 && < 1.8
, transformers >= 0.2 && < 0.7
, transformers-compat >= 0.3 && < 0.8
, ansi-wl-pprint >= 0.6.8 && < 0.7

if flag(process)
build-depends: process >= 1.0 && < 1.7
Expand Down
2 changes: 1 addition & 1 deletion src/Options/Applicative/BashCompletion.hs
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ bashCompletionQuery pinfo pprefs richness ws i _ = case runCompletion compl ppre
-- If there was a line break, it would come across as a different completion
-- possibility.
render_line :: Int -> Doc -> String
render_line len doc = case lines (displayS (renderPretty 1 len doc) "") of
render_line len doc = case lines (renderShowS (layoutPretty (LayoutOptions (AvailablePerLine len 1.0)) doc) "") of
[] -> ""
[x] -> x
x : _ -> x ++ "..."
Expand Down
6 changes: 4 additions & 2 deletions src/Options/Applicative/Builder.hs
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,9 @@ import Options.Applicative.Builder.Completer
import Options.Applicative.Builder.Internal
import Options.Applicative.Common
import Options.Applicative.Types
import Options.Applicative.Help.Pretty
import Options.Applicative.Help.Chunk
import Options.Applicative.Help.Pretty
import Options.Applicative.Help.Types (renderHelp)

-- Readers --

Expand Down Expand Up @@ -545,7 +546,8 @@ prefs m = applyPrefsMod m base
, prefColumns = 80
, prefHelpLongEquals = False
, prefHelpShowGlobal = False
, prefTabulateFill = 24 }
, prefTabulateFill = 24
}

-- Convenience shortcuts

Expand Down
10 changes: 10 additions & 0 deletions src/Options/Applicative/Help/Ann.hs
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{-# LANGUAGE FlexibleInstances #-}

module Options.Applicative.Help.Ann
( Ann(..)
) where

import Options.Applicative.Help.Style

newtype Ann = AnnStyle SetStyle
deriving (Eq, Show)
9 changes: 9 additions & 0 deletions src/Options/Applicative/Help/Chunk.hs
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
{-# LANGUAGE FlexibleInstances #-}

module Options.Applicative.Help.Chunk
( Chunk(..)
, chunked
Expand All @@ -11,6 +13,7 @@ module Options.Applicative.Help.Chunk
, paragraph
, extractChunk
, tabulate
, chunkFlatAlt
) where

import Control.Applicative
Expand Down Expand Up @@ -134,3 +137,9 @@ tabulate _ [] = mempty
tabulate size table = pure $ vcat
[ indent 2 (fillBreak size key <+> value)
| (key, value) <- table ]

-- | By default, @('chunkFlatAlt' x y)@ renders as @x@. However when 'group'ed,
-- @y@ will be preferred, with @x@ as the fallback for the case when @y@
-- doesn't fit.
chunkFlatAlt :: Chunk Doc -> Chunk Doc -> Chunk Doc
chunkFlatAlt x y = pure (flatAlt (extractChunk x) (extractChunk y))
3 changes: 2 additions & 1 deletion src/Options/Applicative/Help/Core.hs
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,8 @@ import Prelude hiding (any)

import Options.Applicative.Common
import Options.Applicative.Types
import Options.Applicative.Help.Pretty
import Options.Applicative.Help.Chunk
import Options.Applicative.Help.Pretty

-- | Style for rendering an option.
data OptDescStyle
Expand Down Expand Up @@ -157,6 +157,7 @@ foldTree prefs s (MultNode xs) =
where
mult_wrap [_] = NeverRequired
mult_wrap _ = MaybeRequired

foldTree prefs s (AltNode b xs) =
(\x -> (x, NeverRequired))
. fmap groupOrNestLine
Expand Down
Loading