Fix: use stringifyRequest instead of absolute paths in loader output #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per Webpack's documentation, the loader-utils package's stringifyRequest method should be used by loaders to avoid hash-breaking absolute paths: https://webpack.js.org/contribute/writing-a-loader/#absolute-paths
|
Can we get an update on any progress getting this merged? |
|
@redoPop Have you reached out to the maintainers about getting this code reviewed and merged? Your fork has been working great for me, and I'd love to get it merged and start pointing to newer versions of this loader. Thanks for your contribution!! |
|
I've not reached out to @pcardune except by filing this PR. Paul: if there are any merge blockers, please let me know. It's not clear to me why Travis choked at the npm install stage; could you restart that build? |
|
I've been MIA for a bit. The build failed for unknown reasons. I just restarted it. Assuming everything passes, I'll go ahead and merge + make a release. Probably by Friday. |
|
version 1.7.1 has been released. Thanks for your patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per Webpack's documentation on building loaders, the loader-utils package's
stringifyRequestmethod should be used by loaders to avoid hash-breaking absolute paths. (See this article for more details on the broken hash problem.)This PR applies Webpack's recommendation to handlebars-loader.
All tests pass. Since the stringifyRequest method is a part of the Webpack loader-utils package and acts as a drop-in replacement for JSON.stringify I didn't think additional tests seemed necessary, but please let me know if you'd like to see something added.