Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: deploy init call #82

Closed
wants to merge 1 commit into from
Closed

Conversation

noyyyy
Copy link

@noyyyy noyyyy commented Oct 30, 2022

#81 draft. The test coverage is not perfect and I wonder why 🤔

image

@pcaversaccio pcaversaccio self-assigned this Oct 30, 2022
@pcaversaccio pcaversaccio added the enhancement New feature or request label Oct 30, 2022
@pcaversaccio
Copy link
Owner

Thx for the PR. The reason why you don't achieve full coverage is that you don't test for the else branch (initCall.length==0) in your tests. In any case, closing this PR due to my comments here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants