Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💥 Add ERC1155MetadataURI Implementation Logic #34

Merged
merged 21 commits into from
Dec 28, 2022

Conversation

jtriley-eth
Copy link
Contributor

@jtriley-eth jtriley-eth commented Dec 22, 2022

PR Checklist


Feature

This PR implements a basic ERC1155MetadataURI contract with an owner and minter authentication system. The contract is not feature-complete nor does this PR implement a full suite of unit tests. This will be done in an additional PR.

@pcaversaccio pcaversaccio changed the title Erc1155 ERC1155MetadataURI Implementation Dec 23, 2022
@pcaversaccio pcaversaccio added the feature 💥 New feature or request label Dec 23, 2022
@pcaversaccio pcaversaccio marked this pull request as ready for review December 23, 2022 09:50
@pcaversaccio pcaversaccio marked this pull request as draft December 23, 2022 09:50
Copy link
Owner

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some first review feedback - looks very promising!

src/tokens/interfaces/IERC1155Receiver.vy Show resolved Hide resolved
src/tokens/interfaces/IERC1155Receiver.vy Show resolved Hide resolved
test/tokens/mocks/ERC1155ReceiverMock.sol Outdated Show resolved Hide resolved
test/tokens/mocks/ERC1155ReceiverMock.sol Outdated Show resolved Hide resolved
test/tokens/mocks/ERC1155ReceiverMock.sol Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Show resolved Hide resolved
jtriley-eth and others added 11 commits December 23, 2022 18:14
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
Co-authored-by: Pascal Marco Caversaccio <pcaversaccio@users.noreply.github.com>
Signed-off-by: JT <Jtriley15@gmail.com>
src/tokens/interfaces/IERC1155Receiver.vy Show resolved Hide resolved
test/tokens/mocks/ERC1155InvalidReceiverMock.sol Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Show resolved Hide resolved
src/tokens/ERC1155.vy Outdated Show resolved Hide resolved
src/tokens/ERC1155.vy Outdated Show resolved Hide resolved
@pcaversaccio pcaversaccio changed the title ERC1155MetadataURI Implementation ERC1155MetadataURI Implementation Logic Dec 27, 2022
@jtriley-eth jtriley-eth marked this pull request as ready for review December 27, 2022 18:04
@jtriley-eth
Copy link
Contributor Author

NOTE: This PR includes only the implementation logic for the ERC1155 token. A subsequent PR will be created with the testing logic.

Copy link
Owner

@pcaversaccio pcaversaccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

image

@pcaversaccio pcaversaccio merged commit d6fd1fc into pcaversaccio:erc1155 Dec 28, 2022
@pcaversaccio pcaversaccio changed the title ERC1155MetadataURI Implementation Logic 💥 Add ERC1155MetadataURI Implementation Logic Feb 1, 2023
@pcaversaccio pcaversaccio added this to the 0.0.1 milestone Feb 1, 2023
@pcaversaccio pcaversaccio added the optimisation ⚡️ Code optimisations (e.g. gas improvements) label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💥 New feature or request optimisation ⚡️ Code optimisations (e.g. gas improvements)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants