-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MNT: Shellchecking bash scripts #184
Closed
KaushikMalapati
wants to merge
975
commits into
pcdshub:help-options-style
from
KaushikMalapati:bash
Closed
MNT: Shellchecking bash scripts #184
KaushikMalapati
wants to merge
975
commits into
pcdshub:help-options-style
from
KaushikMalapati:bash
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… a git repo in the wrong place
Bare repo script
Fully test the event masks and fix temp file name
Added extra bracket to fix issue with last elif statement
changes to run makepeds also in s3df
Enh/makepeds s3df more
Changes to ioctool
… the epicsArchChecker script.
add spyder bash script and a line for finding duplicates was added to…
fix takepeds for elog script
camViewer start & stop acquisition
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
ENH: add permission handling to ioc-deploy
ENH: check for github early to avoid long timeouts, decrease usage of git clone
ENH: allow in-script tagging in ioc-deploy
DOC: minor docstring errors from renamed cli args
Co-authored-by: Zachary Lentz <ZLLentz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Very minor edits that don't change anything important.
I shellchecked the bash scripts in /scripts (making edits based on warnings, errors and info messages that shellcheck gave). Some notes and questions I have are:
stopdaq: # shellcheck source=/reg/g/pcds/dist/pds/rix/scripts/setup_env.sh
restartdaq: # shellcheck source=/reg/g/pcds/dist/pds/rix/scripts/setup_env.sh
checkcnf: # shellcheck source=/reg/g/pcds/dist/pds/rix/scripts/setup_env.sh
$()
for commands, using -gt instead of >, using grep -c or pgrep instead of grep | wc -l and ps | grep, and checking exit codes directly with if cmd; or if !cmd instead of cmd; if [$?]I also found a tool called shfmt which we could add a precommit job for. Here is an example of the diff it would print for kinit_helper
It basically formats things nicely. I have the indenting set to four spaces right now, but it could be a different number or tabs instead. I haven't formatted anything yet because I don't want to add this unilaterally,
Motivation and Context
#182
To standardize style and fix existing shellcheck issues so that future contributors only see pre-commit/workflow errors related to their changes instead of what was already there.
How Has This Been Tested?
Interactively
Where Has This Been Documented?
N/A