Refactor input to be able to set inputs as a pure hash (Fixes #235) #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
trunet
commented
Jan 8, 2020
trunet
commented
- Also added .sync.yml to set default rspec moch and configure .travis.yml after pdk update
- Renamed prospector to inputs and prospector5 to prospector
trunet
force-pushed
the
input-refactor
branch
from
c1eca4d
to
93482e8
Compare
|
Looks great - I'm going to try and get one more release in before merging this just in case we have to work out any issues before releasing with this merged too. I run the master branch of this repo in production, and intend on switching to this implementation as soon as we get things merged so we should know if we run in to issues before rolling the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.