Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the filestream input type #297

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Add support for the filestream input type #297

merged 1 commit into from
Jan 10, 2022

Conversation

smokris
Copy link
Contributor

@smokris smokris commented Dec 26, 2021

…since the default log input type is deprecated in beats-7.16.

@smokris smokris force-pushed the filestream branch 2 times, most recently from 63494bc to 09f7360 Compare January 2, 2022 00:45
pcfens
pcfens reviewed Jan 3, 2022
View reviewed changes
manifests/input.pp Outdated Show resolved Hide resolved
@pcfens pcfens merged commit c8bc5b4 into pcfens:master Jan 10, 2022
@shamil
Copy link

shamil commented May 24, 2022 •
edited
Loading

This change causing issues,

Evaluation Error: Error while evaluating a Function Call, 'versioncmp' parameter 'a' expects a String value, got Boolean (file: modules/filebeat/manifests/params.pp, line: 172, column: 6)

I guess because the filebeat_version fact has the boolean false value, since this fact requires filebeat to be installed.

cc @pcfens

shamil added a commit to bringg/puppet-filebeat that referenced this pull request May 24, 2022
@shamil
Revert "Add support for the 'filestream' input type (pcfens#297)"
aa6c356 
This reverts commit c8bc5b4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcfens pcfens pcfens left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smokris @shamil @pcfens