Add missing options to JSON decoding config #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this - I just pushed this to the forge as v4.14.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
this PR adds
expand_keys,document_idandignore_decoding_erroroptions for JSON decoding.For completeness I've added
ignore_decoding_errortotemplates/prospector.yml.erb, as this option was already available before version 7. The other two were added in 7.5 and 7.11 respectively, so I've added those totemplates/input.yml.erbonly.These options exist with the same names in the
ndjson-Parser for filestream inputs. While this PR does not fix #323, it shouldn't cause any additional issues in that regard, either.If this makes it into a release soon, I'd be super happy, but no worries if not.
Cheers,
antiz