Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert change to confine in filebeat_version #88

Closed
wants to merge 1 commit into from

Conversation

teancom
Copy link

@teancom teancom commented Feb 10, 2017

The change in e5ebb2e breaks with the following error:

Error loading fact /var/lib/puppet/lib/facter/filebeat_version.rb: /var/lib/puppet/lib/facter/filebeat_version.rb:3: syntax error,
 unexpected ':', expecting kEND
  confine kernel: %w(Linux Windows)
                 ^
Error loading fact /var/lib/puppet/lib/facter/filebeat_version.rb: /var/lib/puppet/lib/facter/filebeat_version.rb:3: syntax error,
 unexpected ':', expecting kEND
  confine kernel: %w(Linux Windows)

on my machine with ruby 1.8.7, puppet 3.8.7, and facter 2.4.6. By reverting to the previous syntax, it works again. Everything else in the module appears to be compatible with the versions I have installed.

@pcfens
Copy link
Owner

pcfens commented Feb 12, 2017

I cherry picked this in instead of merging here so that I could add a comment that fixes tests.

I'll try and get something pushed to the forge shortly.

@pcfens pcfens closed this Feb 12, 2017
@teancom
Copy link
Author

teancom commented Feb 13, 2017

Thank you! I really appreciate both the module and how quickly you took care of this (very minor) issue. Cheers!

@teancom teancom deleted the facter_fix branch February 13, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants