-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work-in-progress RDF/XML parser #9
Conversation
cc @phillord if you want to see where this is going |
Just to make sure you are aware: rudf provides a simple RDF/XML parser: https://github.com/Tpt/rudf/blob/master/lib/src/rio/xml.rs |
@Tpt Also got this now https://github.com/phillord/raptor-rs |
@Tpt : mine however supports |
…ey contain comments
Finally, this is feature-complete ! I still need to do a bit of refactoring, in particular to reduce code duplication and complexity, but this version behaves correctly against the RDF/XML test suite, including errors (it fails where a failure is expected). The only exception is the Streaming (i.e. iterating over the produced triples and unwraping the result) the Gene Ontology (go.owl) takes about 5~10 seconds on my machine, but there is probably still some optimisations to be carried out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, it looks really good.
I suggested a few changes. Some of them (error chaining vs. linking, regex vs. pest) are more discussion prompts than requirement -- I'm ok with merging the PR even if they are left as is.
I know that last commit cost you 😉, much appreciated. |
@pchampin : my only regret is not being able to add better error reports, I should have used |
Hi!
This is a work in progress branch, so it's not clear to merge right now, but this is how far I am currently with an RDF/XML parser. I'm parsing correctly
mostall of the RDF/XML 1.1 examples, and I need to add the tests fromrdf-test
.I'll also feature-gate the parser behind an XML feature since it requires an additional dependency (
quick-xml
).Missing features
error-chain
tothiserror
for error management #8 is resolved)rdf:parseType="Literal"
(this is likely to need a PR inquick-xml
)rdf:parseType="Collection"