Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow printing annotations popups #173

Closed
gtache opened this issue Mar 16, 2021 · 7 comments
Closed

Allow printing annotations popups #173

gtache opened this issue Mar 16, 2021 · 7 comments
Labels
enhancement New feature or request Viewer Viewer Module

Comments

@gtache
Copy link
Contributor

gtache commented Mar 16, 2021

So that users can print a document with their comments on it.
@pcorless
Copy link
Owner

Any special requirements for presentation? Guessing a mirror more or less of the swing component?

@gtache
Copy link
Contributor Author

gtache commented Mar 17, 2021 •
edited
Loading

Exactly, it should look more or less the same as the swing components. Only the opened/visible ones would be printed of course.

@pcorless pcorless added the Viewer Viewer Module label Nov 28, 2022
@pcorless pcorless mentioned this issue Nov 28, 2022
Closed
@pcorless pcorless added the enhancement New feature or request label Nov 28, 2022
@pcorless
Copy link
Owner

Couple corner cases:

  • how do we handle popups that have been moved outside of the page margins when printing?
  • do we assume we only print popups that intersect the page component?

@pcorless
Copy link
Owner

Getting there. Should be working by end of week

image

@pcorless
Copy link
Owner

image
Here is some printed popup output. @gtache how important is the "glue" that links the text annotation to the popup? The current code uses transparency which can really increase the print job size. Do you know if the "glue" is preferred and if it can have a solid colour?
image
(Glue)

pcorless pushed a commit that referenced this issue Apr 16, 2023
Merge branch 'master' into GH-173.printing.popup.annotations
3090bd2
pcorless pushed a commit that referenced this issue Apr 16, 2023
GH-173 build out popup printing a bit further to respect isOpen and p…
c407da5 
…arent annotation print flag.
pcorless pushed a commit that referenced this issue Apr 16, 2023
GH-173 add popup 'glue' effect linking markup annotation and popup wh…
9621ed3 
…en printing.
pcorless pushed a commit that referenced this issue Apr 18, 2023
GH-173 tidied up the paint code to make sure union only gets call whe…
587e556 
…n the glue is visible.
@pcorless
Copy link
Owner

Add the glue for printed ouput:
image

pcorless pushed a commit that referenced this issue Apr 19, 2023
GH-173 clean up object deletion and some paint clipping issues
2e8f93d
pcorless pushed a commit that referenced this issue May 8, 2023
Merge branch 'master' into GH-173.printing.popup.annotations
4b8a511 
# Conflicts:
#	core/core-awt/src/main/java/org/icepdf/core/pobjects/annotations/Annotation.java
#	core/core-awt/src/main/java/org/icepdf/core/pobjects/annotations/MarkupAnnotation.java
#	core/core-awt/src/main/java/org/icepdf/core/pobjects/annotations/PopupAnnotation.java
pcorless pushed a commit that referenced this issue May 8, 2023
GH-173 merge conflicts.
6631532
pcorless added a commit that referenced this issue May 8, 2023
@pcorless
GH-173 printable popup annotations (#265)
416b29b
pcorless pushed a commit that referenced this issue May 9, 2023
GH-173 couple checks for printing less than ideal popups.
e350485
pcorless pushed a commit that referenced this issue May 10, 2023
GH-173 fix a some scaling issues with popups that are generated with …
1ff1fd8 
…the no scale flag.
pcorless pushed a commit that referenced this issue May 10, 2023
GH-173 add a basic border for the printable popups.
9ae9ea9
@pcorless
Copy link
Owner

Released as part of 7.1.0

pcorless pushed a commit that referenced this issue Jun 13, 2023
GH-173 respect dynamic font size.
23142f7
pcorless pushed a commit that referenced this issue Jun 13, 2023
GH-173 update isPrintFitToMargin to take into account popup dimension…
08e4952 
…s when caculating page scaling factor.
pcorless pushed a commit that referenced this issue Jun 22, 2023
GH-173 apply page scaling to popup annotations fonts.
0c382a6
pcorless added a commit that referenced this issue Jul 14, 2023
@pcorless
GH-173 popup annotation printing tweaks (#277)
e1f0cab
pcorless pushed a commit that referenced this issue Jul 26, 2023
GH-173 fix tree lock issue when setting/getting default font size.
973b444
pcorless pushed a commit that referenced this issue Jul 27, 2023
GH-173 address line wrapping issue with printing popup annotations.
bc86d1e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Viewer Viewer Module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcorless @gtache