Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-80 Broke Highlight/Underline/Strikethrough #182

Closed
gtache opened this issue Apr 6, 2021 · 4 comments · Fixed by #184
Closed

GH-80 Broke Highlight/Underline/Strikethrough #182

gtache opened this issue Apr 6, 2021 · 4 comments · Fixed by #184

Comments

@gtache
Copy link
Contributor

gtache commented Apr 6, 2021

Basically, we get something like this when trying to highlight:
2021-04-06_13h52_31
I guess it's simply a side effect of the new font system and could be resolved by improving the font detection/printing.
@pcorless
Copy link
Owner

pcorless commented Apr 7, 2021

I have a few samples like this as well. I've generally found it wasn't great before either but that doesn't really matter now. Could you send over a few samples and I'll prioritise. It's a really small piece of code in question but more examples will help figure out what happening with the transforms.

pcorless pushed a commit that referenced this issue Apr 14, 2021
GH-182 a few teaks to address some test selection regression.
2036db1
@pcorless pcorless linked a pull request Apr 14, 2021 that will close this issue
GH-182 #184
Merged
@pcorless
Copy link
Owner

Can you take a look at the PR/branch. Still terrible code but it does address my corner cases for bad text selection bounds.

pcorless pushed a commit that referenced this issue Apr 21, 2021
GH-182 potential fix to derive ascent/descent from bbox if not set fr…
b9acbd2 
…om font descriptor.
pcorless pushed a commit that referenced this issue Apr 27, 2021
GH-182 further refinement for text selection regressions.
6c90fae
pcorless added a commit that referenced this issue Apr 27, 2021
@pcorless
GH-182 text selection bounds improvements (#184)
880560c
@pcorless
Copy link
Owner

Found a few regressions.

@pcorless pcorless reopened this Apr 27, 2021
pcorless pushed a commit that referenced this issue Apr 29, 2021
GH-182 fix for remaining text selection regression (that I know about).
4170297
@pcorless
Copy link
Owner

Committed a fix to address the remaining text selection issues. It seems that descent isn't always negative in the FontDescriptor which was messing up the bounds. Sizes can also be negative which can confuse the issue.

pcorless pushed a commit that referenced this issue Aug 24, 2021
GH-182 fix for remaining text selection regression (that I know about).
064e963
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-182 pcorless/icepdf
2 participants
@pcorless @gtache