Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reopens Open file dialog if wrong file type has been selected #19

Closed
gtache opened this issue Feb 6, 2020 · 0 comments · Fixed by #27
Closed

Reopens Open file dialog if wrong file type has been selected #19

gtache opened this issue Feb 6, 2020 · 0 comments · Fixed by #27
Labels
bug Something isn't working Viewer Viewer Module

Comments

@gtache
Copy link
Contributor

gtache commented Feb 6, 2020

At the moment, if the user selects a non-pdf file, an error is displayed and the open file dialog closes. It would be more user-friendly for the open file dialog to reopen in this case, as it was surely a misclick from the user and they probably still want to open a file.
gtache added a commit to gtache/icepdf that referenced this issue Feb 6, 2020
@gtache
pcorlessGH-19 Reopens open dialog when a file other than pdf has been…
e045232 
… selected
@gtache gtache mentioned this issue Feb 6, 2020
Merged
@pcorless pcorless added bug Something isn't working Viewer Viewer Module labels Feb 11, 2020
@pcorless pcorless added this to the 6.4.0 milestone Feb 11, 2020
pcorless pushed a commit that referenced this issue Feb 11, 2020
@gtache
GH-19 Reopens open dialog when a file other than pdf has been selected (
de15995 
#27)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Viewer Viewer Module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-19 Reopens open dialog when a file other than pdf has been selected gtache/icepdf
2 participants
@pcorless @gtache