Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guess print format #130

Merged
merged 10 commits into from
Sep 23, 2020
Merged

Guess print format #130

merged 10 commits into from
Sep 23, 2020

Conversation

gtache
Copy link
Contributor

@gtache gtache commented Aug 21, 2020

Closes #129

@pcorless
Copy link
Owner

I like this change as it seem to make more sense then original implementation and of course the user can still over ride the page size via the dialog.
Could you also tidy up:

  • swingController.savePrinterProperties()
  • remove the ViewerPropertiesManager.PROPERTY_PRINT_MEDIA_* constants.
  • Remove the default page values form ICEpdfDefault.properties

@pcorless pcorless merged commit 7550457 into pcorless:master Sep 23, 2020
@gtache gtache deleted the guessPrint branch September 23, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcorless pcorless pcorless approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Guess print format for document
2 participants
@gtache @pcorless