Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-323 fix file descriptor leak on window #333

Merged
merged 4 commits into from
Jan 25, 2024
Merged

GH-323 fix file descriptor leak on window #333

merged 4 commits into from
Jan 25, 2024

Conversation

pcorless
Copy link
Owner

  • it's document in a few JDK bug tracks but the basic problem is there appears to be a file descriptor leak on Windows when using
ByteBuffer mappedFileByteBuffer = documentFileChannel.map(
    FileChannel.MapMode.READ_ONLY, 0, documentFileChannel.size());

Reworked the file copy to play more nicely with the windows JDK.

@pcorless pcorless merged commit fecef3f into master Jan 25, 2024
@pcorless pcorless deleted the GH-323.potential.file.descriptor branch January 25, 2024 04:04
pcorless added a commit that referenced this pull request Jan 30, 2024
@pcorless
GH-323 fix file descriptor leak on window (#333)
14a0e87 
(cherry picked from commit fecef3f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pcorless