GH-345 icon followup tweaks #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
pcorless
commented
May 9, 2024
pcorless
commented
- bring code formatting inline with project defaults.
- few layout tweak to make layout less dependent on width height. Removed the getHeightValueForIconSize() call.
- set toolbar buttons to to an empty boarder to make the toolbar a little closer to the original layout. Height is a little higher then before but I think this is more in line with swing defaults.
…descriptor in its name
…components, providing a way to customize all app icons
… `selected` state
…to `org.icepdf.ri.iconpack`)
…etch or shrink according to their content on their own
…ton` with logic based on its children
…er based on an `ImageIcon`
…-345.icon.followup.tweaks # Conflicts: # viewer/viewer-awt/src/main/java/org/icepdf/ri/common/DropDownButton.java # viewer/viewer-awt/src/main/java/org/icepdf/ri/common/SwingViewBuilder.java # viewer/viewer-awt/src/main/java/org/icepdf/ri/common/utility/outline/OutlinesTree.java # viewer/viewer-awt/src/main/java/org/icepdf/ri/common/widgets/AbstractColorButton.java # viewer/viewer-awt/src/main/java/org/icepdf/ri/images/DefaultIconPack.java # viewer/viewer-awt/src/main/java/org/icepdf/ri/images/IconPack.java # viewer/viewer-awt/src/main/java/org/icepdf/ri/images/Images.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.