GH-69 Displaying filtered annotations #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm king of leaning to the focus loss for visibility as this is all annotation panel driven. Have you had user feedback on this yet? |
|
The testers haven't made any comment regarding this, but I also agree that it would be a better way to do that. I'll look into implementing it. |
…cus loss, hides popup if needed, adds convenience method to PageViewComponentImpl
pcorless
reviewed
Mar 30, 2021
viewer/viewer-awt/src/main/java/org/icepdf/ri/common/views/PageViewComponentImpl.java
Show resolved
Hide resolved
pcorless
previously approved these changes
Mar 30, 2021
|
Looks good, just few conflicts to tidy up. |
pcorless
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #69
Depends on #67
If the user is in the annotation panel and filtering the annotations, the document will only display the filtered annotations.
When the user clicks in the document, all the annotations are displayed. (Maybe a better condition would be if the MarkupAnnotationPanel or its children have lost focus)