Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename center to origin in ellipse function params #67

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Rename center to origin in ellipse function params #67

merged 1 commit into from
Sep 19, 2023

Conversation

lyonbeckers
Copy link
Contributor

Fixes #65

@boozook boozook added the enhancement New feature or request label Sep 19, 2023
@boozook boozook merged commit d4a2fe1 into pd-rs:main Sep 19, 2023
1 check passed
@boozook
Copy link
Member

boozook commented Sep 20, 2023

@lyonbeckers,
Actually that was not so wrong, because there is "origin" really, also named as "pivot-point". Yes, this is the center of the thing, but in other engines pivot-point can be set by user.

Okay, nerd mode is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boozook boozook boozook approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Draw ellipse parameter is mislabeled as center
2 participants
@lyonbeckers @boozook