Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade bitflags to 2.4.1 #241

Closed
wants to merge 1 commit into from

Conversation

GnomedDev
Copy link
Contributor

@GnomedDev GnomedDev commented Nov 7, 2023

This is a breaking change, so should be tagged with 0.6.

Replaces the outdated bitflags 1.2.1 with 2.4.1, which reduces downstream duplicate dependencies and allows removing the ChannelsIter as this is automatically added by the bitflags macro.

@GnomedDev GnomedDev marked this pull request as draft November 7, 2023 14:08
@pdeljanov pdeljanov added this to the v0.6.0 milestone Jan 6, 2024
@GnomedDev GnomedDev marked this pull request as ready for review January 6, 2024 23:16
@pdeljanov
Copy link
Owner

Thanks for doing this. Unfortunately, I already inadvertently did this while working on the dev-0.6 branch. I appreciate the effort!

@pdeljanov pdeljanov closed this Mar 11, 2024
@GnomedDev
Copy link
Contributor Author

No problem

@GnomedDev GnomedDev deleted the upgrade-bitflags branch March 11, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants