Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mkv: get metadata from info element #277

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

dedobbin
Copy link
Contributor

@dedobbin dedobbin commented Apr 25, 2024

As discussed here, #273
I just placed the segment title as a tag.
When dumping the metadata for an mka file that has both a "tag title" and a "segment title" it looks like this

Metadata {
    revisions: [
        MetadataRevision {
            tags: [
                Tag {
                    std_key: None,
                    key: "TITLE",
                    value: String(
                        "real_title",
                    ),
                },
            ],
            visuals: [],
            vendor_data: [],
        },
        MetadataRevision {
            tags: [
                Tag {
                    std_key: None,
                    key: "TITLE",
                    value: String(
                        "tag_title",
                    ),
                },
...

If you think there is a neater way let me know!

symphonia-format-mkv/src/segment.rs Outdated Show resolved Hide resolved
symphonia-format-mkv/src/segment.rs Outdated Show resolved Hide resolved
symphonia-format-mkv/src/demuxer.rs Outdated Show resolved Hide resolved
@dedobbin dedobbin force-pushed the feature/mkv-segment-title-metadata branch from 202685c to be2d459 Compare August 30, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants