Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isomp4: fix zero track duration for fragmented mp4 #317

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

sscobici
Copy link

@sscobici sscobici commented Oct 4, 2024

trak.mdia.mdhd.duration sometimes is 0 for fragmented mp4.
There are two files from Dolby Vision for which video packets cannot be extracted because of that:

  • iOS_P5_GlassBlowing2_3840x2160@59.94fps_15200kbps.mp4
  • P81_GlassBlowing2_3840x2160@59.94fps_15200kbps_fmp4.mp4

Solution: take duration from trak.tkhd.duration
Please review.

@pdeljanov
Copy link
Owner

Logic looks good to me. The rustfmt CI is failing because the config requires the nightly toolchain: cargo +nightly fmt. I'll push a commit fixing the clippy errors.

@pdeljanov
Copy link
Owner

I have fixed the clippy lints in dd61030. You should be able to rebase and force push your PR to clear the CI failures.

@sscobici sscobici force-pushed the fix-track-duration2 branch 2 times, most recently from a38870b to e2e97de Compare October 6, 2024 04:36
@sscobici sscobici force-pushed the fix-track-duration2 branch from e2e97de to b2c7781 Compare October 6, 2024 04:43
@pdeljanov pdeljanov merged commit 7563d47 into pdeljanov:dev-0.6 Oct 7, 2024
7 of 11 checks passed
@pdeljanov
Copy link
Owner

Thanks, merged. Seems the CI is a bit broken unfortunately, but I don't think your change will impact any of that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants