core: add pts, dts #347
Open
core: add pts, dts #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding pts (former ts) and dts.
This was done in two commits: the first for renaming
tstopts, and the second for addingdts(i64), which can be negative for video.Audio crates will not need to pass
dtswhen creating the Packet using thenewmethods. Video packets are planned to be created withnew_from_boxed_slice_v, which will include adtsparameter.new_from_boxed_slice_vis not present in this commit, but I have changes for MP4 to include DTS. Waiting for MP4 refactoring if you plan to do it.For some reason, only the
oggcrate usespacket.tsdirectly, which is why it was impacted as well.Can the
oggcrate be rewritten to use internal structures instead?