feat: add base QueryKitException #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdevito3
approved these changes
Mar 2, 2024
Owner
pdevito3
left a comment
pdevito3
left a comment
There was a problem hiding this comment.
cool, great idea! will add this in the next release for sure
thanks for the contribution!
This was referenced Nov 9, 2025
Closed
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #25.
I've added in a new
QueryKitExceptionexception class, and updated the existing exceptions to inherit from it.I've added some documentation to cover this new exception base class, and I've updated the documentation which referred to
FilterParsingExceptionwhich I think should have beenParsingException.If I've done anything incorrect with this pull request and contribution let me know and I'll get it fixed!
Thanks.