Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stoke color and non-stroke color in PDFGraphicState #287

Merged
merged 1 commit into from
Oct 12, 2019

Conversation

tongbaojia
Copy link
Contributor

Dear Pdfminer maintainers.

I ran into this issue finding that the color coding for the curve is not saved.
This is traced down to a potential bug.
.color is not an attribute of graphicstate, while scolor and ncolor are.
I think this was a typo from before, and the issue was fixed in do_G and do_g but not in do_RG.

@pietermarsman
Copy link
Member

I think you are right.

In e6ad15a (in PR #37 by @begnini) the .scolor (stroking color) and .ncolor (non-stroking color) where introduced. However, only .do_SCN used these attributes. Six other functions (.do_G(), .do_g(), .do_RG(), .do_rg(), .do_K(), .do_k()) use the .color attribute, which I find very perculiar.

In 2231f08 (in PR #129 by @pquentin) 2 methods where fixed: .do_G() and .do_g(), the others remained the same.

@keshavbohra
Copy link

Can anyone change the build for pdfminer.six in PyPI with the above changes.

@pietermarsman
Copy link
Member

This should be merged before releasing

@tataganesh
Copy link
Member

All PR's should be branched out of "develop" and merged into develop if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants