Fix logging for pdf2txt #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietermarsman
requested changes
Nov 2, 2019
There was a problem hiding this comment.
Hi @hason,
Thanks for fixing this issue. I've made some small remarks about removing or moving things from/in this PR.
I also wonder if this effects the debug output of the dumppdf.py command. I think there should also be a logging.basicConfig() statement included there.
hason
changed the title
pietermarsman
requested changes
Nov 5, 2019
|
Fixed logging in dumppdf, pdf2txt and pdfdiff. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #313