Fix for when 'trailer' is indented #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pietermarsman
requested changes
Oct 10, 2020
|
@pietermarsman I just pushed a new commit addressing your code review 👍 |
|
Oops! Merged this while it was broken... |
pietermarsman
added a commit
that referenced
this pull request
Oct 25, 2020
This reverts commit ec223d1.
pietermarsman
added a commit
that referenced
this pull request
Oct 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Thanks for improving pdfminer.six! Please include the following information to
help us discuss and merge this PR:
Fix a bug where
trailerbeing indented caused a bug. Thanks to @pietermarsman for suggesting the fix.Closes #214
How Has This Been Tested?
There is an example script and PDF in #214.
Checklist
works (N/A -> we don't really want to add this PDF to our test suite, correct?)
version
is not necessary
verified that this is not necessary
CHANGELOG.md