-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix value error and key error #574
Fix value error and key error #574
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good and harmless. Can you add a FIxes line to the CHANGELOG.md?
I updated the CHANGELOG. but @pietermarsman something is wrong with the bot running the test? |
The bot raises:
|
Can you merge/rebase with the develop branch? This will fix the cicd failure. |
@pietermarsman is this PR ready to merge? Thanks :) |
.get
to protect getting a key that doesn't exist.The code change is pretty simple and in general good practice in python so I think they should be adopted.
Sorry that I couldn't share the original PDF document as explained in the issue.
How Has This Been Tested?
Can confirm that with these fixes the document can be processed.
Checklist
works
version
is not necessary
verified that this is not necessary
CHANGELOG.md