Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #795 #798

Closed
wants to merge 4 commits into from
Closed

Fix #795 #798

wants to merge 4 commits into from

Conversation

KunalGehlot
Copy link
Contributor

@KunalGehlot KunalGehlot commented Aug 23, 2022

Pull request

Patch fix for the breaking change in the Pillow library where mode 8 is changed to L as pointed out by joaquimcampos in #795

Documentation updates: Added FAQ questions and made small spelling, and grammar fixes.

Documentation updates: Added how-to for extracting coordinates, text and font-info

How Has This Been Tested?

Tested with nox

Doctest summary
===============
   14 tests
    0 failures in tests
    0 failures in setup code
    0 failures in cleanup code
build succeeded.

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this PR is mixing documentation improvement with unrelated code changes.

Could you split it into two PR's with a one focus?

@pietermarsman
Copy link
Member

Continue in #828 such that I can make changes

@pietermarsman
Copy link
Member

I've split this PR into #827, #828 and #829 and merged them. I could not keep the lineage to your commits in #829 because I had to split a commit.

Thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants