-
Notifications
You must be signed in to change notification settings - Fork 932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix from-source and Python 3.12 build by removing hard-coded version (#922) #923
Conversation
not sure why it doesn't get mentioned there but this fixes #922 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great. I've rewritten the CHANGELOG.md a bit, and merged master into this branch.
Can you look at the failing tests? If that is fixed it is ready to be merged.
@dhdaines I've fixed the tests. Perhaps you can give it another look next week. I'm planning to merge it next week. |
Hi! Sorry for the late reply... I was on top of a mountain for a few days. Seems to all work quite well for me on Python 3.12. As far as I can tell the release workflow should work in the same way but I wouldn't be able to test that :) |
No worries. I haven't responded in quite a while, and I was not on a mountain 😄 The work you put in here is much appreciated! |
Switch to using setuptools-git-versioning instead of a hardcoding the version at release time with a default version string that was not friendly to PEP440, Python 3.12, or building from git source.
Checklist