Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix from-source and Python 3.12 build by removing hard-coded version (#922) #923

Merged
merged 19 commits into from
Dec 28, 2023

Conversation

dhdaines
Copy link
Contributor

Switch to using setuptools-git-versioning instead of a hardcoding the version at release time with a default version string that was not friendly to PEP440, Python 3.12, or building from git source.

Checklist

  • [ x ] I have read CONTRIBUTING.md.
  • [ x ] I have added a concise human-readable description of the change to CHANGELOG.md.
  • [ x ] I have tested that this fix is effective or that this feature works.
  • [ x ] I have added docstrings to newly created methods and classes.
  • [ x ] I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@dhdaines dhdaines changed the title Fix version (fixes: #922) Fix from-source and Python 3.12 build by removing hard-coded version (fixes: #922) Nov 16, 2023
@dhdaines
Copy link
Contributor Author

not sure why it doesn't get mentioned there but this fixes #922

@dhdaines dhdaines changed the title Fix from-source and Python 3.12 build by removing hard-coded version (fixes: #922) Fix from-source and Python 3.12 build by removing hard-coded version (#922) Nov 16, 2023
@dhdaines dhdaines mentioned this pull request Nov 16, 2023
Copy link
Member

@pietermarsman pietermarsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I've rewritten the CHANGELOG.md a bit, and merged master into this branch.

Can you look at the failing tests? If that is fixed it is ready to be merged.

@pietermarsman pietermarsman mentioned this pull request Dec 22, 2023
@pietermarsman
Copy link
Member

@dhdaines I've fixed the tests. Perhaps you can give it another look next week. I'm planning to merge it next week.

@dhdaines
Copy link
Contributor Author

@dhdaines I've fixed the tests. Perhaps you can give it another look next week. I'm planning to merge it next week.

Hi! Sorry for the late reply... I was on top of a mountain for a few days. Seems to all work quite well for me on Python 3.12.

As far as I can tell the release workflow should work in the same way but I wouldn't be able to test that :)

@pietermarsman pietermarsman added this pull request to the merge queue Dec 28, 2023
Merged via the queue into pdfminer:master with commit 38d48aa Dec 28, 2023
10 checks passed
@pietermarsman
Copy link
Member

No worries. I haven't responded in quite a while, and I was not on a mountain 😄

The work you put in here is much appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants