Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update minimum version of futures-util
This is a complicated one. There was a soundness bug in futures-task rust-lang/futures-rs#2795 so it was fixed in a point release (0.3.31) even though it's a breaking change. But other crates, including futures-util, weren't updated to "depend on" the newer release, even though they now don't compile against the older release. This suddenly broke the cotton-minver build, which used the old futures-util 0.3.11 (because it *directly* depends on it) but the new futures-task 0.3.31 (because it only *indirectly* depends on it, and the minver build does direct-minimal-versions only). Fix this by depending on a later version of futures-util.
- Loading branch information
b7dbf59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the breakage!
No, futures-util 0.3.31 requires futures-task 0.3.31+. The problem here is in old futures-util, for example 0.3.30 requires futures-task 0.3.30+ so you will encounter the problem if you try to partially raise versions of futures-* not all at once.
I yanked futures-util 0.3.30 and older, so I think this issue will be fixed.
b7dbf59
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, oops, I'm not sure I realised that just mentioning your crate would notify you. Sounds like it was a sticky situation and you did the right thing!