Skip to content

Commit

Permalink
Re-enable ingest_external_file with mmap_read in crash test
Browse files Browse the repository at this point in the history
Summary: I suspect the issue called out in facebook#9357 was fixed in facebook#11328

Test Plan: `make blackbox_crash_test` for hours
  • Loading branch information
pdillinger committed Jan 4, 2024
1 parent 81b6296 commit 932f471
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions tools/db_crashtest.py
Original file line number Diff line number Diff line change
Expand Up @@ -568,11 +568,6 @@ def finalize_and_sanitize(src_params):
if dest_params["mmap_read"] == 1:
dest_params["use_direct_io_for_flush_and_compaction"] = 0
dest_params["use_direct_reads"] = 0
if dest_params["file_checksum_impl"] != "none":
# TODO(T109283569): there is a bug in `GenerateOneFileChecksum()`,
# used by `IngestExternalFile()`, causing it to fail with mmap
# reads. Remove this once it is fixed.
dest_params["ingest_external_file_one_in"] = 0
if (
dest_params["use_direct_io_for_flush_and_compaction"] == 1
or dest_params["use_direct_reads"] == 1
Expand Down

0 comments on commit 932f471

Please sign in to comment.