Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsupported shell: sh, please specify another shell via --pep582 <SHELL> #1502

Closed
cdleonard opened this issue Nov 8, 2022 · 2 comments
Closed

Unsupported shell: sh, please specify another shell via --pep582 <SHELL> #1502

cdleonard opened this issue Nov 8, 2022 · 2 comments
Labels
🐛 bug Something isn't working ❓ help wanted Extra attention is needed

Comments

@cdleonard
Copy link
Contributor

Running eval "$(pdm582 --pep)" fails containers which use non-bash shells by default, for example dash or busybox.

The generate shell code is very simple so "sh" should just be allowed.
@cdleonard cdleonard added the 🐛 bug Something isn't working label Nov 8, 2022
@frostming
Copy link
Collaborator

SGTM, can you contribute the code for dash and busybox?

@frostming frostming added the ❓ help wanted Extra attention is needed label Nov 9, 2022
@cdleonard
Copy link
Contributor Author

The code for bash works fine, there are no compat issues.

cdleonard added a commit to cdleonard/pdm that referenced this issue Nov 10, 2022
@cdleonard
fix: Handle "sh" and "dash" in print_pep582_command (pdm-project#1502)
e759417 
Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
cdleonard added a commit to cdleonard/pdm that referenced this issue Nov 10, 2022
@cdleonard
fix: Handle "sh" and "dash" in print_pep582_command (pdm-project#1502)
98577c9 
Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
frostming pushed a commit that referenced this issue Nov 10, 2022
@cdleonard
fix: Handle "sh" and "dash" in print_pep582_command (#1502) (#1511)
a4f083c 
Signed-off-by: Leonard Crestez <cdleonard@gmail.com>

Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
@j178 j178 mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug Something isn't working ❓ help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdleonard @frostming