Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider packages installed if the venv includes them from the system-site #2216

Closed
sanmai-NL opened this issue Aug 30, 2023 · 0 comments · Fixed by #2219
Closed

Consider packages installed if the venv includes them from the system-site #2216

sanmai-NL opened this issue Aug 30, 2023 · 0 comments · Fixed by #2219
Assignees
@frostming
Labels
⭐ enhancement Improvements for existing features

Comments

@sanmai-NL
Copy link
Contributor

sanmai-NL commented Aug 30, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

When a venv is created with the include-system-site-packages configuration option on, PDM still installs PyPI packages specified in the lockfile.

See python-poetry/poetry#8359
See also #1787

Describe the solution you'd like

See python-poetry/poetry#8359
@sanmai-NL sanmai-NL added the ⭐ enhancement Improvements for existing features label Aug 30, 2023
@frostming frostming self-assigned this Aug 31, 2023
frostming added a commit that referenced this issue Aug 31, 2023
@frostming
feat: Consider packages installed if the venv includes them from the …
7320b3a 
…system-site

Fixes #2216

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming mentioned this issue Aug 31, 2023
Merged
2 tasks
@sanmai-NL sanmai-NL mentioned this issue Sep 29, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frostming frostming

Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Consider packages installed if the venv includes them from the system-site pdm-project/pdm
2 participants
@sanmai-NL @frostming