Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare the candidate before calculating the hash #1108

Merged
merged 2 commits into from
Jun 1, 2022
Merged

Prepare the candidate before calculating the hash #1108

merged 2 commits into from
Jun 1, 2022

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Jun 1, 2022

Pull Request Check List

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Related to #1103

@frostming frostming changed the base branch from main to dev June 1, 2022 06:59
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2022

Codecov Report

Merging #1108 (4572e90) into dev (a0fa365) will decrease coverage by 0.04%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##              dev    #1108      +/-   ##
==========================================
- Coverage   83.92%   83.88%   -0.05%     
==========================================
  Files          79       79              
  Lines        6911     6918       +7     
  Branches     1638     1639       +1     
==========================================
+ Hits         5800     5803       +3     
- Misses        762      764       +2     
- Partials      349      351       +2     
Flag Coverage Δ
unittests 83.65% <75.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pdm/models/repositories.py 76.68% <75.00%> (-0.18%) ⬇️
pdm/models/candidates.py 87.63% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0fa365...4572e90. Read the comment docs.

@frostming frostming merged commit ef72353 into dev Jun 1, 2022
@frostming frostming deleted the fix/1103 branch June 1, 2022 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include hashes in exported requirements.txt file for zip files
2 participants