-
-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix minimum version requirement for tomlkit #1539
Conversation
PDM uses the method `unwrap` from `tomlkit` which was added only in `tomlkit-0.11.0`. When I upgraded PDM from an old version and ran it, I got an error because of this.
Can you also update the pdm hash by running |
Codecov ReportBase: 85.38% // Head: 85.33% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1539 +/- ##
==========================================
- Coverage 85.38% 85.33% -0.05%
==========================================
Files 91 91
Lines 8034 8034
Branches 1907 1907
==========================================
- Hits 6860 6856 -4
- Misses 785 788 +3
- Partials 389 390 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Could you do it yourself please? I have some trouble with that, getting weird errors: |
Sure, done. |
Sorry, it should be |
PDM uses the method
unwrap
fromtomlkit
which was added only intomlkit-0.11.0
. When I upgraded PDM from an old version and ran it, I got an error because of this.Pull Request Check List
I think these tasks are unnecessary for such a small change:
news/
describing what is new.Describe what you have changed in this PR.