Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minimum version requirement for tomlkit #1539

Merged
merged 4 commits into from
Dec 2, 2022
Merged

Fix minimum version requirement for tomlkit #1539

merged 4 commits into from
Dec 2, 2022

Conversation

snowwm
Copy link
Contributor

@snowwm snowwm commented Dec 2, 2022

PDM uses the method unwrap from tomlkit which was added only in tomlkit-0.11.0. When I upgraded PDM from an old version and ran it, I got an error because of this.

Pull Request Check List

I think these tasks are unnecessary for such a small change:

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

PDM uses the method `unwrap` from `tomlkit` which was added only in `tomlkit-0.11.0`. When I upgraded PDM from an old version and ran it, I got an error because of this.
@frostming
Copy link
Collaborator

Can you also update the pdm hash by running pdm lock --refresh?

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2022

Codecov Report

Base: 85.38% // Head: 85.33% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (597b46b) compared to base (cfe2aa3).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1539      +/-   ##
==========================================
- Coverage   85.38%   85.33%   -0.05%     
==========================================
  Files          91       91              
  Lines        8034     8034              
  Branches     1907     1907              
==========================================
- Hits         6860     6856       -4     
- Misses        785      788       +3     
- Partials      389      390       +1     
Flag Coverage Δ
unittests 85.16% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/models/repositories.py 79.92% <0.00%> (-0.79%) ⬇️
src/pdm/termui.py 89.85% <0.00%> (-0.73%) ⬇️
src/pdm/cli/actions.py 78.50% <0.00%> (-0.25%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snowwm
Copy link
Contributor Author

snowwm commented Dec 2, 2022

Could you do it yourself please? I have some trouble with that, getting weird errors:
[RequirementError]: Invalid marker: Invalid marker: '; platform_system == \\"Windows\\""', parse error at '; platfo'

@frostming
Copy link
Collaborator

Sure, done.

@snowwm
Copy link
Contributor Author

snowwm commented Dec 2, 2022

Sorry, it should be 0.11.1 due to python-poetry/tomlkit@1cb4c25
Or maybe you know if there were more bugfixes later.

pdm.lock Outdated Show resolved Hide resolved
@frostming frostming merged commit 40cc734 into pdm-project:main Dec 2, 2022
@snowwm snowwm deleted the patch-1 branch December 2, 2022 16:45
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants