Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: eliminate the importlib.resources warnings #1661

Merged
merged 3 commits into from
Feb 3, 2023

Conversation

frostming
Copy link
Collaborator

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fix #1660

@codecov-commenter
Copy link

Codecov Report

Base: 85.21% // Head: 85.22% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ffa550e) compared to base (91a500d).
Patch coverage: 91.66% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1661   +/-   ##
=======================================
  Coverage   85.21%   85.22%           
=======================================
  Files          92       92           
  Lines        8563     8580   +17     
  Branches     1851     1853    +2     
=======================================
+ Hits         7297     7312   +15     
- Misses        850      852    +2     
  Partials      416      416           
Flag Coverage Δ
unittests 85.03% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/__version__.py 71.42% <50.00%> (-3.58%) ⬇️
src/pdm/cli/utils.py 80.96% <50.00%> (ø)
src/pdm/cli/commands/completion.py 90.47% <100.00%> (ø)
src/pdm/compat.py 89.36% <100.00%> (+4.51%) ⬆️
src/pdm/models/in_process/__init__.py 100.00% <100.00%> (ø)
src/pdm/models/specifiers.py 77.54% <100.00%> (ø)
src/pdm/utils.py 86.47% <0.00%> (-0.61%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 92f5f5f into main Feb 3, 2023
@frostming frostming deleted the compat-importlib-resources branch February 3, 2023 01:22
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeprecationWarning is emitted for importlib-resources.
3 participants