Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyright/eglot config for emacs #1721

Merged
merged 8 commits into from
Feb 20, 2023
Merged

Conversation

pakelley
Copy link
Contributor

@pakelley pakelley commented Feb 17, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • [N/A] Test cases added for changed code.

Describe what you have changed in this PR.

MS's python lang server (as well as lsp-python-ms) are archived in favor of pyright. Additionally, eglot will be packaged with Emacs once Emacs 29 is released.

@pakelley
Copy link
Contributor Author

Adding a news fragment now...

@pakelley
Copy link
Contributor Author

Also, I'm curious why Emacs's config is in a different section than all of the other editors? If it's arbitrary I'd be happy to move it.

@pakelley
Copy link
Contributor Author

Sorry for the noise, but the config listed for Neovim works for Emacs too. If it seems helpful, I could add a note about doing it that way to the Emacs section, since it may be simpler in some cases.

@frostming
Copy link
Collaborator

@pakelley I am not an expert of emacs and I have no objections about the changes.

@pakelley
Copy link
Contributor Author

Sounds good, well if you don't mind I'll move the emacs section next to the other editors and add a section about configuring via pyproject.toml.
Thanks for all of your work on pdm, it's the first python package management tool I've used that isn't painful :)

@pakelley
Copy link
Contributor Author

Alright, as long as you're happy with this, I've made all of the changes I wanted. Let me know if there's anything you'd like updated.

Copy link
Collaborator

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frostming frostming merged commit 9d67a49 into pdm-project:main Feb 20, 2023
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants