Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the resolution order to prefer the packages causing the conflict #1760

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

frostming
Copy link
Collaborator

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #1752

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change

Comparison is base (89935cc) 85.11% compared to head (e60261a) 85.11%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1760   +/-   ##
=======================================
  Coverage   85.11%   85.11%           
=======================================
  Files          92       92           
  Lines        8664     8666    +2     
  Branches     1872     1873    +1     
=======================================
+ Hits         7374     7376    +2     
  Misses        868      868           
  Partials      422      422           
Flag Coverage Δ
unittests 84.92% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/resolver/providers.py 94.36% <100.00%> (+0.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit edc0018 into main Mar 8, 2023
@frostming frostming deleted the resolve-preference branch March 8, 2023 09:53
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pdm takes forever to resolve s3fs==2023.3.0 and boto3
2 participants