Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not validate against locked groups in lock command #1797

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Close #1796

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming changed the title fix: do not validate agains locked groups in lock command fix: do not validate against locked groups in lock command Mar 30, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 89.74% and project coverage change: -0.01 ⚠️

Comparison is base (146daa2) 85.13% compared to head (8494645) 85.13%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
- Coverage   85.13%   85.13%   -0.01%     
==========================================
  Files          99       99              
  Lines        8974     8985      +11     
  Branches     1946     1947       +1     
==========================================
+ Hits         7640     7649       +9     
- Misses        907      908       +1     
- Partials      427      428       +1     
Flag Coverage Δ
unittests 84.95% <89.74%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/fix/__init__.py 72.22% <0.00%> (ø)
src/pdm/core.py 90.69% <89.65%> (+0.37%) ⬆️
src/pdm/cli/actions.py 77.58% <100.00%> (-0.35%) ⬇️
src/pdm/cli/commands/base.py 100.00% <100.00%> (ø)
src/pdm/cli/filters.py 92.64% <100.00%> (+0.10%) ⬆️
src/pdm/signals.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit d39a8e5 into main Mar 30, 2023
@frostming frostming deleted the fix/lock-group-validate branch March 30, 2023 02:39
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pdm.lock - pdm 2.5.0b1] Cannot add optional-dependencies to lockfile after initial generation of lockfile
2 participants