Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed zsh completions by replacing brackets in option descriptions #1848

Merged
merged 3 commits into from
Apr 25, 2023
Merged

fix: fixed zsh completions by replacing brackets in option descriptions #1848

merged 3 commits into from
Apr 25, 2023

Conversation

crai0
Copy link

@crai0 crai0 commented Apr 21, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Fixed #1847 by replacing the brackets in the option descriptions with parentheses.

@codecov-commenter
Copy link

codecov-commenter commented Apr 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (d6db424) 85.38% compared to head (f77579b) 85.30%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1848      +/-   ##
==========================================
- Coverage   85.38%   85.30%   -0.08%     
==========================================
  Files          99       99              
  Lines        9032     9032              
  Branches     1954     1954              
==========================================
- Hits         7712     7705       -7     
- Misses        889      896       +7     
  Partials      431      431              
Flag Coverage Δ
unittests 85.11% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit 4409f96 into pdm-project:main Apr 25, 2023
@frostming
Copy link
Collaborator

Thanks

@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh completions not working for some commands
3 participants