Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(cli): improve cli reference display #1853

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

noirbizarre
Copy link
Member

@noirbizarre noirbizarre commented Apr 25, 2023

Pull Request Checklist

  • A news fragment is added in news/ describing what is new (I don't think this requires a dedicated changelog entry, but if this is the case, I'll add it)
  • Test cases added for changed code. (NA: doc generate properly)

Describe what you have changed in this PR.

Improve cli reference display by:

  • fixes dunders being rendered as bold markdown
  • adds the missing spaces before (default: or [env var
  • monospace some known reccuring references (pyproject.toml, pdm.lock, .pdm-python, :all, :pre and :post)
  • apply the same casing to all help messages (Title)
  • use the same format for all env vars
  • use the same format (backticked) for parameters in help

@noirbizarre noirbizarre force-pushed the doc/tidy-cli-reference branch from dc4513d to 04b7620 Compare April 26, 2023 00:38
- fixes dunders being rendered as bold markdown
- adds the missing spaces before `(default:` or `[env var`
- monospace some known reccuring references (`pyproject.toml`, `pdm.lock`, `.pdm-python`, `:all`, `:pre` and `:post`)
- apply the same casing to all help messages (Title)
- use the same format for all env vars
- use the same format (backticked) for parameters in help
@noirbizarre noirbizarre force-pushed the doc/tidy-cli-reference branch from 04b7620 to 6278b78 Compare April 26, 2023 00:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0cf6578) 85.31% compared to head (6278b78) 85.32%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1853   +/-   ##
=======================================
  Coverage   85.31%   85.32%           
=======================================
  Files          99       99           
  Lines        9037     9042    +5     
  Branches     1955     1955           
=======================================
+ Hits         7710     7715    +5     
  Misses        896      896           
  Partials      431      431           
Flag Coverage Δ
unittests 85.13% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/commands/base.py 100.00% <ø> (ø)
src/pdm/cli/commands/build.py 84.61% <ø> (ø)
src/pdm/cli/options.py 93.80% <100.00%> (ø)
src/pdm/cli/utils.py 83.23% <100.00%> (+0.29%) ⬆️
src/pdm/core.py 93.02% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit fec6ccd into pdm-project:main Apr 26, 2023
@noirbizarre noirbizarre deleted the doc/tidy-cli-reference branch April 26, 2023 01:44
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants