Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create venv when running pdm init -n #1862

Merged
merged 1 commit into from
Apr 28, 2023
Merged

feat: create venv when running pdm init -n #1862

merged 1 commit into from
Apr 28, 2023

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

When running pdm init -n(non-interactive mode), a venv will be created by default. Previously, the selected Python will be used under PEP 582 mode.

Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2023

Codecov Report

Patch coverage: 72.00% and project coverage change: +0.03 🎉

Comparison is base (450e971) 85.40% compared to head (8f8825b) 85.44%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1862      +/-   ##
==========================================
+ Coverage   85.40%   85.44%   +0.03%     
==========================================
  Files          99       99              
  Lines        9067     9075       +8     
  Branches     1958     1961       +3     
==========================================
+ Hits         7744     7754      +10     
+ Misses        894      892       -2     
  Partials      429      429              
Flag Coverage Δ
unittests 85.25% <72.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/cli/actions.py 80.82% <0.00%> (+0.43%) ⬆️
src/pdm/project/lockfile.py 85.71% <45.45%> (-14.29%) ⬇️
src/pdm/cli/commands/init.py 94.52% <100.00%> (ø)
src/pdm/project/core.py 90.62% <100.00%> (+1.18%) ⬆️
src/pdm/project/project_file.py 91.07% <100.00%> (+1.27%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit f2f67ca into main Apr 28, 2023
@frostming frostming deleted the feat/init-venv branch April 28, 2023 03:59
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants