Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pakcage without peotry config [tool.poetry.build] script would raise keyError #1938

Merged
merged 1 commit into from
May 19, 2023

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented May 19, 2023

Fixes #1935

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

…ld raise keyError

Fixes #1935

Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2023

Codecov Report

Patch coverage: 50.00% and project coverage change: -0.02 ⚠️

Comparison is base (18f3a04) 85.16% compared to head (86f9e7f) 85.15%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1938      +/-   ##
==========================================
- Coverage   85.16%   85.15%   -0.02%     
==========================================
  Files          99       99              
  Lines        9250     9254       +4     
  Branches     2013     2015       +2     
==========================================
+ Hits         7878     7880       +2     
- Misses        938      939       +1     
- Partials      434      435       +1     
Flag Coverage Δ
unittests 84.95% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/formats/poetry.py 84.93% <50.00%> (-0.99%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frostming frostming merged commit df0013f into main May 19, 2023
@frostming frostming deleted the frostming/issue1935 branch May 19, 2023 08:11
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pakcage without peotry config [tool.poetry.build] script would raise keyError
2 participants