Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: PDM corrupts binary executable (ruff) #2054

Merged
merged 4 commits into from
Jun 26, 2023
Merged

Conversation

frostming
Copy link
Collaborator

@frostming frostming commented Jun 26, 2023

Fixes #2045

Supersedes #2046

Signed-off-by: Frost Ming me@frostming.com

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

cc @pawamoy

Fixes #2045

Signed-off-by: Frost Ming <me@frostming.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2023

Codecov Report

Patch coverage: 3.44% and project coverage change: -0.19 ⚠️

Comparison is base (81f7fc4) 84.96% compared to head (04c71d5) 84.78%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2054      +/-   ##
==========================================
- Coverage   84.96%   84.78%   -0.19%     
==========================================
  Files          99       99              
  Lines        9419     9439      +20     
  Branches     2060     2065       +5     
==========================================
  Hits         8003     8003              
- Misses        966      986      +20     
  Partials      450      450              
Flag Coverage Δ
unittests 84.58% <3.44%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/pdm/environments/local.py 48.10% <3.44%> (-16.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming marked this pull request as ready for review June 26, 2023 03:55
Signed-off-by: Frost Ming <me@frostming.com>
Signed-off-by: Frost Ming <me@frostming.com>
@frostming frostming merged commit 96fb903 into main Jun 26, 2023
@frostming frostming deleted the frostming/issue2045 branch June 26, 2023 04:35
@j178 j178 mentioned this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PDM corrupts binary executable (ruff)
2 participants